<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW --- - any2ppm fails to build on architectures without MMU" href="https://bugs.freedesktop.org/show_bug.cgi?id=78709#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW --- - any2ppm fails to build on architectures without MMU" href="https://bugs.freedesktop.org/show_bug.cgi?id=78709">bug 78709</a> from <a class="email" href="mailto:nravi.n@samsung.com" title="Ravi Nanjundappa <nravi.n@samsung.com>"> Ravi Nanjundappa</a> <pre>Comment on <a href="attachment.cgi?id=99045" name="attach_99045" title="Add check for fork() when compiling any2ppm as daemon">attachment 99045</a> <a href="attachment.cgi?id=99045&action=edit" title="Add check for fork() when compiling any2ppm as daemon">[details]</a> Add check for fork() when compiling any2ppm as daemon I feel conditional checking of HAVE_FORK macro, should be seperated out. Because in the above patch, HAVE_FORK has been added in the conditional checking of header file related macros. How about the below change ? diff --git a/test/any2ppm.c b/test/any2ppm.c index b125496..3e0806f 100644 --- a/test/any2ppm.c +++ b/test/any2ppm.c @@ -92,8 +92,10 @@ #define SOCKET_PATH "./.any2ppm" #define TIMEOUT 60000 /* 60 seconds */ +#if HAVE_FORK #define CAN_RUN_AS_DAEMON 1 #endif +#endif #define ARRAY_LENGTH(A) (sizeof (A) / sizeof (A[0]))</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>