<html>
    <head>
      <base href="https://bugs.freedesktop.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW --- - Should define all disabled features as 0 to avoid build failure"
   href="https://bugs.freedesktop.org/show_bug.cgi?id=83359">83359</a>
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>chris@chris-wilson.co.uk
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Should define all disabled features as 0 to avoid build failure
          </td>
        </tr>

        <tr>
          <th>QA Contact</th>
          <td>cairo-bugs@cairographics.org
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>julien.isorce@gmail.com
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>1.12.16
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>general
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>cairo
          </td>
        </tr></table>
      <p>
        <div>
        <pre>Created <span class=""><a href="attachment.cgi?id=105566" name="attach_105566" title="build: define no features as 0">attachment 105566</a> <a href="attachment.cgi?id=105566&action=edit" title="build: define no features as 0">[details]</a></span>
build: define no features as 0

Currently in cairo-gl.h there is:
#if CAIRO_HAS_GL_SURFACE || CAIRO_HAS_GLESV2_SURFACE

When building cairo with --disable-glesv2 then the compiler warns that
CAIRO_HAS_GLESV2_SURFACE is not defined.
If those warnings are treated as errors then the build just fails (ex: webkit)

The attached patch ensure all stuffs under put in NO_FEATURES are defined as 0,
even for features defaulted to "no". Because currently only features defaults
to auto or yes are put into NO_FEATURES when disabled.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the QA Contact for the bug.</li>
      </ul>
    </body>
</html>