<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Quartz backend build failure (git master)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84569#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Quartz backend build failure (git master)"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84569">bug 84569</a>
from <span class="vcard"><a class="email" href="mailto:ranma42@gmail.com" title="Andrea Canciani <ranma42@gmail.com>"> <span class="fn">Andrea Canciani</span></a>
</span></b>
<pre>(In reply to ~suv from <a href="show_bug.cgi?id=84569#c2">comment #2</a>)
<span class="quote">> Remaining error with patch applied:
>
> CC cairo-quartz-image-surface.lo
> cairo-quartz-image-surface.c:382:11: error: implicit declaration of function
> '_cairo_surface_is_quartz' is invalid in C99
> [-Werror,-Wimplicit-function-declaration]
> if (! _cairo_surface_is_quartz (surface)) {
> ^
> 1 error generated.
> make[3]: *** [cairo-quartz-image-surface.lo] Error 1
>
>
>
> Compiler (from Xcode 4.3.2):
>
> $ clang --version
> Apple clang version 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn)</span >
Oops, I did not realize that the issue also affected quartz-image (I was
building with default flags, which do not enable it).
(In reply to Bryce Harrington from <a href="show_bug.cgi?id=84569#c3">comment #3</a>)
<span class="quote">> Andrea, you're on the right path, that's half the fix.
>
> For the remaining error(s) suv reported, do this:
>
> 1. _cairo_surface_is_quartz() needs to not be static, since it's used in
> another file.
>
> 2. Move the declaration of _cairo_surface_is_quartz() into the
> cairo-quartz-private.h header. Define it as cairo_private like other
> routines listed here.</span >
Did this in
<a href="http://cgit.freedesktop.org/~ranma42/cairo/commit/?id=84c68269f7e24ebaf9bf02702feeb775a5bac53e">http://cgit.freedesktop.org/~ranma42/cairo/commit/?id=84c68269f7e24ebaf9bf02702feeb775a5bac53e</a>
I also let it run through the testsuite and (besides from some reference images
that might need to be updated) it looks mostly good (except for a couple of
blend modes... will investigate those).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>