<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - test/cairo-test-suite reports wrong max diff comparing different opaque images"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84044#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - test/cairo-test-suite reports wrong max diff comparing different opaque images"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84044">bug 84044</a>
from <span class="vcard"><a class="email" href="mailto:sixtysix@inwind.it" title="Massimo <sixtysix@inwind.it>"> <span class="fn">Massimo</span></a>
</span></b>
<pre>(In reply to Uli Schlachter from <a href="show_bug.cgi?id=84044#c4">comment #4</a>)
<span class="quote">>
> I'd rather fix these problems in pdiff instead of somewhere in the code
> producing these images. In theory, these two code paths are independent from
> each other and pdiff could be used from something else than just the test
> suite.</span >
Agreed, I opted to fix the producer because a failing test
compares an image with many references, but is produced
only once, so with many failures in the test-suite this
extra work is not repeated many times.
OTOH to speed up the execution of the test suite probably it could be
possible to save with the reference also its md5sum, so that for
the exact comparison one computes the md5sum of the output and compares
it against many references with only one image loop.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>