<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:fanc999@yahoo.com.tw" title="Fan, Chun-wei <fanc999@yahoo.com.tw>"> <span class="fn">Fan, Chun-wei</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Compilation errors with MSVC after recent changes to 'cairo-path-stroke-traps.c'"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84908">bug 84908</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>fanc999@yahoo.com.tw
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Compilation errors with MSVC after recent changes to 'cairo-path-stroke-traps.c'"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84908#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Compilation errors with MSVC after recent changes to 'cairo-path-stroke-traps.c'"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84908">bug 84908</a>
from <span class="vcard"><a class="email" href="mailto:fanc999@yahoo.com.tw" title="Fan, Chun-wei <fanc999@yahoo.com.tw>"> <span class="fn">Fan, Chun-wei</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=107945" name="attach_107945" title="Another variant to solve the msvc compilation problem">attachment 107945</a> <a href="attachment.cgi?id=107945&action=edit" title="Another variant to solve the msvc compilation problem">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=84908&attachment=107945'>[review]</a>
Another variant to solve the msvc compilation problem
Hi,
I can confirm too that this patch works for me (Visual Studio 2008+, which also
gets this problem). The issue here is that Visual Studio 2005+ is quite strict
on type conversions (so it wants code to be clear enough on conversions), and I
think it makes sense from a correctness and a security point of view. Although
the code might not look that nice, but I think as Hans mentioned, it is
consistent with the rest of Cairo.
Please consider this patch, especially as Cairo does need some update and work
on the Windows side, and making it buildable with Visual Studio would be really
helpful for that work.
Thanks very much for your time, with blessings!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>