<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - cairo-perf-trace failure"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73580#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - cairo-perf-trace failure"
href="https://bugs.freedesktop.org/show_bug.cgi?id=73580">bug 73580</a>
from <span class="vcard"><a class="email" href="mailto:ranma42@gmail.com" title="Andrea Canciani <ranma42@gmail.com>"> <span class="fn">Andrea Canciani</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=110953" name="attach_110953" title="[PATCH] cairo-trace: Extract common helper for _surface_create_similar[_image]()">attachment 110953</a> <a href="attachment.cgi?id=110953&action=edit" title="[PATCH] cairo-trace: Extract common helper for _surface_create_similar[_image]()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73580&attachment=110953'>[review]</a>
[PATCH] cairo-trace: Extract common helper for
_surface_create_similar[_image]()
Review of <span class=""><a href="attachment.cgi?id=110953" name="attach_110953" title="[PATCH] cairo-trace: Extract common helper for _surface_create_similar[_image]()">attachment 110953</a> <a href="attachment.cgi?id=110953&action=edit" title="[PATCH] cairo-trace: Extract common helper for _surface_create_similar[_image]()">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=73580&attachment=110953'>[review]</a>:
-----------------------------------------------------------------
I expressed some concerns about this refactoring on IRC, but I'll also post
them here to keep track of them together with the bug.
While removing some code duplication between similar and similar-image is
ideally good, in practice the two operators have different signatures (they use
different parameters in a different order), so I'm afraid that coalescing both
in a single function makes them more complicated than needed.
I agree that the changes from c1ac8db7e60bcec8235b09729b34154e95790534 should
also apply to similar-image, but I believe that merging the emission of the two
operator is not a good idea.
Ideally I would merge the previous patch (which fixes the
cairo_surface_create_similar_image() function so that it does not pushes more
surfaces than expected on the stack) and (in a separate commit) resync the
implementation of similar and similar-image, possibly by only sharing the code
for _emit_other_obj().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>