<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - cairo-perf-trace failure" href="https://bugs.freedesktop.org/show_bug.cgi?id=73580#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - cairo-perf-trace failure" href="https://bugs.freedesktop.org/show_bug.cgi?id=73580">bug 73580</a> from <a class="email" href="mailto:emanuele.aina@collabora.com" title="Emanuele Aina <emanuele.aina@collabora.com>"> Emanuele Aina</a> <pre>Created <a href="attachment.cgi?id=111958" name="attach_111958" title="[PATCH 3/3] cairo-trace: Extract common helper for _surface_create_similar[_image]()">attachment 111958</a> <a href="attachment.cgi?id=111958&action=edit" title="[PATCH 3/3] cairo-trace: Extract common helper for _surface_create_similar[_image]()">[details]</a> <a href='page.cgi?id=splinter.html&bug=73580&attachment=111958'>[review]</a> [PATCH 3/3] cairo-trace: Extract common helper for _surface_create_similar[_image]() To avoid any divergence between cairo_surface_create_similar_image() and cairo_surface_create_similar() in future, coalesce the code to emit the trace line in a common helper. Unfortunately the signature of the two trace lines are slightly different (in 'similar' the content type precedes width and height, while for 'similar-image' width and height come before the format identifier), but to be able to run new traces with older cairo tools it cannot be changed. This is optional, I still included it in the patchset since I feel that the two implementations may drift again after this resync, leading to subtle bugs.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>