<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - ATOMIC_OP_NEEDS_MEMORY_BARRIER doesn't play well with ThreadSanitizer" href="https://bugs.freedesktop.org/show_bug.cgi?id=90303#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - ATOMIC_OP_NEEDS_MEMORY_BARRIER doesn't play well with ThreadSanitizer" href="https://bugs.freedesktop.org/show_bug.cgi?id=90303">bug 90303</a> from <a class="email" href="mailto:froydnj@gmail.com" title="Nathan Froyd <froydnj@gmail.com>"> Nathan Froyd</a> <pre>(In reply to Chris Wilson from <a href="show_bug.cgi?id=90303#c5">comment #5</a>) > Looks good to me. Something that is missing in that file is that we really > should do > > #if HAVE_CXX11_ATOMIC_PRIMITIVES > #elif HAVE_INTEL_ATOMIC_PRIMITIVES > #elif /* blah */ > #endif I could do that as a followup patch. Where do standalone patches like that get sent? A bug in bugzilla, or straight to the mailing list? (In reply to Behdad Esfahbod from <a href="show_bug.cgi?id=90303#c6">comment #6</a>) > Would you also be able to take a look at improving HarfBuzz (and fontconfig, > which copied the atomic ops from HarfBuzz; but I can do that part myself): > > <a class="bz_bug_link bz_status_NEW " title="NEW - Use C++11 atomic intrinsics" href="show_bug.cgi?id=90305">https://bugs.freedesktop.org/show_bug.cgi?id=90305</a> Sure, I could look at that. I haven't seen any HarfBuzz bits come up when running Firefox through TSan, but it's entirely possible that we only use HarfBuzz on a single thread.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>