<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Memory leak in cairo-script-surface"
href="https://bugs.freedesktop.org/show_bug.cgi?id=91396">91396</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Memory leak in cairo-script-surface
</td>
</tr>
<tr>
<th>Product</th>
<td>cairo
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>general
</td>
</tr>
<tr>
<th>Assignee</th>
<td>chris@chris-wilson.co.uk
</td>
</tr>
<tr>
<th>Reporter</th>
<td>sixtysix@inwind.it
</td>
</tr>
<tr>
<th>QA Contact</th>
<td>cairo-bugs@cairographics.org
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="attachment.cgi?id=117248" name="attach_117248" title="plug a memory leak">attachment 117248</a> <a href="attachment.cgi?id=117248&action=edit" title="plug a memory leak">[details]</a></span>
plug a memory leak
The bug is that in '_emit_recording_surface_pattern' the current cr is
saved on the stack in 'old_cr':
<a href="http://cgit.freedesktop.org/cairo/tree/src/cairo-script-surface.c#n1173">http://cgit.freedesktop.org/cairo/tree/src/cairo-script-surface.c#n1173</a>
if replaying the recording surface 'emit_source' is called it is possible
that the 'current_source' member of surface->cr is finished and in its
place is copied the new source, (for surface_patterns this means that the new
source surface ref count is incremented):
<a href="http://cgit.freedesktop.org/cairo/tree/src/cairo-script-surface.c#n1741">http://cgit.freedesktop.org/cairo/tree/src/cairo-script-surface.c#n1741</a>
but exiting the recursion 'old_cr' is assigned/raw-copied onto surface->cr and
current_source is overwritten without the matching ref count decrement.
compiling cairo with -fsanitize=address Gcc option and running
(cd test; CAIRO_TEST_TARGET=recording ./cairo-test-suite -f user-font-mask )
the report ends with:
...
SUMMARY: AddressSanitizer: 7632 byte(s) leaked in 27 allocation(s).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the QA Contact for the bug.</li>
</ul>
</body>
</html>