<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"" href="https://bugs.freedesktop.org/show_bug.cgi?id=91967#c9">Comment # 9</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Assertion "(_cairo_atomic_int_get (&(&surface->ref_count)->ref_count) > 0)"" href="https://bugs.freedesktop.org/show_bug.cgi?id=91967">bug 91967</a> from <a class="email" href="mailto:alberts.muktupavels@gmail.com" title="Alberts Muktupāvels <alberts.muktupavels@gmail.com>"> Alberts Muktupāvels</a> <pre>(In reply to Bryce Harrington from <a href="show_bug.cgi?id=91967#c8">comment #8</a>) > You've not really answered my questions. Just stating I'm wrong doesn't > clarify anything; I'm married, so I already know I'm always wrong. ;-) Which questions? 1. "First, if we set image to NULL and it hits BAIL, then doesn't it just crash unreferencing it here?" No, it does not crash. 2. "However, backing up a bit... if XShmGetImage() has failed, such that we're destroying &image->base, is any of the rest of the function still valid?" Yes, it is still valid... because it will try to get image differently. 3. "Which makes me wonder if when this error situation is hit, if it'd be better to just exit the function?" No, because then we loose another chance of getting image in different way. > Seriously though, I think either you've misunderstood me or are not > explaining things properly, because I still think your proposed change isn't > correctly implemented for Cairo. Yeah, sounds like I don't understand you or you don't understand me, or maybe both... :( Not correctly in what way? Then please attach patch that is supposed to be correct and I will test it. I can reproduce this, also I am not only one who have hit this bug/problem... Bug report for same problem: <a href="https://github.com/mate-desktop/mate-applets/issues/137">https://github.com/mate-desktop/mate-applets/issues/137</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>