[cairo-commit] cairo BUGS,1.17,1.18 ChangeLog,1.265,1.266

[Carl Worth]

Committed by: cworth

Update of /cvs/cairo/cairo
In directory gabe:/tmp/cvs-serv9854

Modified Files:
	BUGS ChangeLog 
Log Message:

        * test/text_cache_crash.c: Add note that bug has been fixed.
        (main): Instrumentation code for testing cache destruction.

        * test/cairo_test.c (cairo_test): Support tests that produce no
        output, (don't check image if (width,height) == (0,0)).

        * src/cairoint.h: Add #include <assert.h> here rather than in
        multiple .c files.

        * src/cairo_cache.c: Add const qualifier to static
        cache_arrangements table.
        (_cache_sane_state): Remove refcount assertion as it it false
        during the cairo_cache_destroy.
        (_cache_sane_state): #include <assert.h> moved up to cairoint.h
        (_entry_destroy): Fix bug in assertion (used_memory >=
        entry->memory), not >.
        (_cairo_cache_destroy): Fix timing of refcount decrement so that
        the destroy function actually works.


Index: BUGS
===================================================================
RCS file: /cvs/cairo/cairo/BUGS,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -d -r1.17 -r1.18
--- BUGS	11 Nov 2004 20:15:12 -0000	1.17
+++ BUGS	23 Nov 2004 20:53:46 -0000	1.18
@@ -97,3 +97,10 @@
 
 cairo falls over with XFree86 4.2 (probably braindead depth handling
 somewhere).
+
+--
+
+The caches abort when asked for a too-large item, (should be possible
+to trigger by asking for a giant font, "cairo_scale_font (cr, 2000)"
+perhaps). Even if the caches don't want to hold them, we need to be
+able to allocate these objects.

Index: ChangeLog
===================================================================
RCS file: /cvs/cairo/cairo/ChangeLog,v
retrieving revision 1.265
retrieving revision 1.266
diff -u -d -r1.265 -r1.266
--- ChangeLog	14 Nov 2004 18:07:54 -0000	1.265
+++ ChangeLog	23 Nov 2004 20:53:46 -0000	1.266
@@ -1,3 +1,24 @@
+2004-11-23  Carl Worth  <cworth at cworth.org>
+
+	* test/text_cache_crash.c: Add note that bug has been fixed.
+	(main): Instrumentation code for testing cache destruction.
+
+	* test/cairo_test.c (cairo_test): Support tests that produce no
+	output, (don't check image if (width,height) == (0,0)).
+
+	* src/cairoint.h: Add #include <assert.h> here rather than in
+	multiple .c files.
+
+	* src/cairo_cache.c: Add const qualifier to static
+	cache_arrangements table.
+	(_cache_sane_state): Remove refcount assertion as it it false
+	during the cairo_cache_destroy.
+	(_cache_sane_state): #include <assert.h> moved up to cairoint.h
+	(_entry_destroy): Fix bug in assertion (used_memory >=
+	entry->memory), not >.
+	(_cairo_cache_destroy): Fix timing of refcount decrement so that
+	the destroy function actually works.
+
 2004-11-14  Carl Worth  <cworth at cworth.org>
 
 	* src/cairo_gstate.c (_cairo_gstate_select_font): Don't destroy a