[cairo] [PATCH] fix bugs 15797 (1.8) and 18632 (master)

Jeff Muizelaar jeff at infidigm.net
Wed Dec 10 14:10:09 PST 2008


On Wed, Dec 10, 2008 at 05:01:43PM -0500, Jeff Muizelaar wrote:
> On Wed, Dec 10, 2008 at 09:57:10AM +0100, Paolo Bonzini wrote:
> > 
> > > The reason why cairo-gstate.c does not do the stack-copy is that it
> > > incurs significant overhead on renderbench versus plain XRender (and the
> > > heap copy that snuck into 1.6 was even more painful for all work loads).
> > > If you have any doubts over the lifetime, just make the copy and only
> > > worry about if it ever appears on a profile.
> > 
> > No, I don't think there are any doubt over the lifetime, especially if
> > it is pointed out in a comment.
> 
> I don't really like trusting third party code to release the object at a
> specific time, especially if it has callbacks for destruction.
> 
> I plan on applying something like the following patch to trunk.

And to 1.8 too.

-Jeff


More information about the cairo mailing list