[cairo] Possible bug in commit c7ce1b68

Guillaume Ayoub guillaume.ayoub at kozea.fr
Tue Mar 26 06:42:28 PDT 2013


In the _cairo_pdf_surface_add_padded_image_surface() function introduced
in this commit:
http://cgit.freedesktop.org/cairo/commit/?id=c7ce1b68d5370f6e804a6edbf5be4bca3a5b7c57

This code looks like it has a typo:

if (_cairo_fixed_integer_ceil(box.p1.x) < 0 ||
_cairo_fixed_integer_ceil(box.p1.y) < 0 ||
_cairo_fixed_integer_floor(box.p2.y) > w ||
_cairo_fixed_integer_floor(box.p2.y) > h)

The first box.p2.y value should probably be box.p2.x.

I have no idea what the implications of this bug are, or how to
test/reproduce it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://lists.cairographics.org/archives/cairo/attachments/20130326/7abe62f9/attachment.pgp>


More information about the cairo mailing list