<HTML><BODY style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><DIV><DIV>On Aug 6, 2007, at 22:38, Vladimir Vukicevic wrote:</DIV><BR class="Apple-interchange-newline"><BLOCKQUOTE type="cite"><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Here's a patch after a discussion on irc... basically, the backend clone_similar function was called from two places (clip_init_deep_copy and the pattern acquire_surface_for_gradient), but the function isn't a required one for backends to implement.<SPAN class="Apple-converted-space"> </SPAN>So if it ever failed, both of these functions just failed.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">It was hard to hit either of these cases -- the win32 surface didn't implement clone_similar, but it also never used pattern_acquire_surface, and the other would only be hit if you tried to push_group with a mask clip set.</DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Here's a patch that implements fallback for clone_similar; it uses create_similar_scratch and then calls composite with OPERATOR_SOURCE.</DIV></BLOCKQUOTE><BR></DIV><DIV>Would this explain a weird behavior I saw the other day using the Quartz backend? I was doing a push/pop_group, and had a clip shape that was trapezoidal (not rectangular). It worked great on X11, but on Quartz, I got the "extents" of the trapezoid.</DIV><BR><DIV> <SPAN class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 18px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><DIV>--</DIV><DIV>Travis Griggs</DIV><DIV>Objologist</DIV><DIV>One man's blue plane is another man's pink plane.</DIV><BR class="Apple-interchange-newline"></SPAN> </DIV><BR></BODY></HTML>