<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD> <META http-equiv=Content-Type content="text/html; charset=us-ascii"> <META content="MSHTML 6.00.6000.16640" name=GENERATOR></HEAD> <BODY> <DIV dir=ltr align=left>Hey all,</DIV> <DIV dir=ltr align=left> </DIV> <DIV dir=ltr align=left>I sent out this email some time ago but didn't get any feedback. Does anyone have any objection to having a composite_source function in the backends, and a fallback to pixman for the backends that don't support it the way we define it? That would allow big speedups and correct rendering.</DIV> <DIV dir=ltr align=left> </DIV> <DIV dir=ltr align=left>Or is it useless to spend much time and effort on that as SOURCE compositing is not frequently used (and/or no one ever complained about it?) ?</DIV> <DIV dir=ltr align=left> </DIV> <DIV dir=ltr align=left>Antoine</DIV> <DIV dir=ltr align=left> </DIV> <BLOCKQUOTE dir=ltr style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px"> <DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left> <HR tabIndex=-1> From: Antoine Azar [mailto:cairo@antoineazar.com] Sent: Thursday, May 01, 2008 3:35 AM To: 'cairo@cairographics.org' Subject: Bug with paint_with_alpha and perf issues when compositing with SOURCE </DIV> <DIV></DIV> <DIV>Hey all,</DIV> <DIV>I discussed this already with cworth and am looking for feedback on this issue.</DIV> <DIV> </DIV> <DIV>paint_with_alpha will return an "incorrect" result when used with a SOURCE operator. According to the doc, paint_with_alpha is "A drawing operator that paints the current source everywhere within the current clip region using a mask of constant alpha value <CODE>alpha</CODE>. The effect is similar to <A class=link href="http://www.cairographics.org/manual/cairo-cairo-t.html#cairo-paint"><CODE class=function>cairo_paint()</CODE></A>, but the drawing is faded out using the alpha value."</DIV> <DIV> </DIV> <DIV>So doing the following:</DIV> <DIV> cairo_set_source_rgb (cr, 0.2, 0.6, 0.9); cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE); cairo_paint_with_alpha (cr, 0.5); Should return a blueish color with a 0.5 alpha all over the surface with no more trace of the previous contents. Currently, the blueish color is being composited like an OVER operator. This is because we avoid the SOURCE operator and replace it to accomodate different backends. So we implement our own definition of SOURCE which is: (src IN mask IN clip) ADD (dst OUT (mask IN clip))                      //see _clip_and_composite_source in cairo-surface-fallback.c According to the doc, in the paint_with_alpha case, this definition should actually be: (src IN mask IN clip) ADD (dst OUT clip) Carl and I came up with a solution that I included in the attached patch. It works nicely and corresponds to our doc. However it does worsen performance, which is already terrible when compositing with a SOURCE operator. The performance benchmark shows the paint_with_alpha-solid-rgb-source test is 10 times SLOWER than the over equivalent (you'd expect SOURCE compositing to be faster than OVER). Quartz is 40 times faster than pixman on that test. This patch will fix the rendering of paint_with_alpha, but we should look into improving the performance of SOURCE compositing. I'm not sure how each backend interprets it, but we shouldn't be penalizing all of them for variations. The _clip_and_composite_source function really is painful to look at for such a simple operation. Maybe we could have a composite_source function in the backends, and fallback to pixman for the backends that don't support it the way we define it. That would allow us to remove the nasty: if (mask) { /* These operators aren't interpreted the same way by the backends; * they are implemented in terms of other operators in cairo-gstate.c */ assert (op != CAIRO_OPERATOR_SOURCE && op != CAIRO_OPERATOR_CLEAR); } from _cairo_surface_composite and get really good speed ups both in the backends and in pixman. Comments and feedback welcome! Thanks, Antoine</DIV></BLOCKQUOTE></BODY></HTML>