<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi,<div><br></div><div>I'm building cairo HEAD on Solaris.</div><div>I found 2 minor issues.</div><div><br></div><div>1) cairo-spline.c</div><div>_cairo_spline_decompose_into is a void function, but it has a return statement with an expression.</div><div>Although the expression is also void, it's still not allowed by Sun Studio by default.</div><div>If I use features-extensions, it give a warning.</div><div><br></div><div>Here's the C standard.</div><div><span class="Apple-style-span" style="font-family: Arial; ">=============================================<br>6.8.6.4 The return statement <br><br>Constraints <br><br>1. A return statement with an expression shall not appear in a function whose return type is void. A return statement without an expression shall only appear in a function whose return type is void.<br>=============================================</span></div><div><br></div><div>2) cairo-script-interpreter.c, cairo-script-operators.c, cairo-script-scanner.c</div><div>They include byteswap.h, which is not exist on Solaris.</div><div><br></div><div>We should do something as cairo-wideint-type-private.h does.</div><div>Or just get it included?</div><div><br></div><div>Thanks,</div><div><br></div><div>Ginn</div><div><br></div><div><div> <span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">--------</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Ginn Chen</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Software Engineer, Browser Team</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Sun Microsystems, Inc.</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Phone: x82869 / +86-10-62673869</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Fax: +86-10-62780969</div><br class="Apple-interchange-newline"></span></div></span> </div><br></div></body></html>