Added CAIRO_MUTEX_UNLOCK before return NULL if visual is not found<br>Fixed small indentation problem.<br><br><br><div class="gmail_quote">On Wed, Mar 17, 2010 at 10:56 PM, Oleg Romashin <span dir="ltr"><<a href="mailto:romaxa@gmail.com">romaxa@gmail.com</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><br><br><div class="gmail_quote"><div><div></div><div class="h5">On Wed, Mar 17, 2010 at 8:03 PM, Soeren Sandmann <span dir="ltr"><<a href="mailto:sandmann@daimi.au.dk" target="_blank">sandmann@daimi.au.dk</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div><div></div><div>Oleg Romashin <<a href="mailto:romaxa@gmail.com" target="_blank">romaxa@gmail.com</a>> writes:<br> <br> > Updated cairo 16bpp format support patch:<br> > <a href="https://bugs.freedesktop.org/attachment.cgi?id=34084&action=edit" target="_blank">https://bugs.freedesktop.org/attachment.cgi?id=34084&action=edit</a><br> ><br> > 1) Removed CAIRO_CONTENT_COLOR16<br> > 2) Fixed rendering from 16bpp image surface -> 16bpp Xlib surface<br> ><br> > Can we get this version into upstream?<br> <br> </div></div>In this:<br> <br> + Visual *visual = NULL;<br> + Screen *screen = DefaultScreenOfDisplay(display->display);<br> + int j;<br> + for (j = 0; j < screen->ndepths; j++) {<br> + Depth *d = &screen->depths[j];<br> + if (d->depth == 16 && d->nvisuals && &d->visuals[0]) {<br> + visual = &d->visuals[0];<br> + break;<br> + }<br> + }<br> <br> don't you need to check that the visual is (a) the right class and (b)<br> the masks are actually 565 and not, say, 655?<br></blockquote></div></div><div><br>Is this version better: ?<br><a href="https://bugs.freedesktop.org/attachment.cgi?id=34161&action=edit" target="_blank">https://bugs.freedesktop.org/attachment.cgi?id=34161&action=edit</a><br> <br>Br, Oleg<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <br> <br> Soren<br> </blockquote></div><br> </blockquote></div><br>