[cairo-bugs] [Bug 4192] _cairo_ft_unscaled_font_fini does not decrement font_map->num_open_faces

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Aug 22 14:44:56 PDT 2005


Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=4192          
     




------- Additional Comments From cworth at cworth.org  2005-08-22 14:44 -------
Created an attachment (id=2992)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=2992&action=view)
Adjust num_open_faces before each call to _cairo_ft_unscaled_font_fini

Here's a patch to fix the bug, (including the assert statement from the
previous patch).

It's not lovely in that the decrement of num_open_faces is distant from the
call
to FT_Done_Face. But it's not obvious to me what a cleaner solution would be,
(since passing the font_map parameter down into unscaled_font_fini would cause
the locking to deviate from local-only, which seems worse).          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.



More information about the cairo-bugs mailing list