[cairo-bugs] [Bug 4414] SIGILL caused by libcairo when running gnome-terminal

[bugzilla-daemon at freedesktop.org]

Please do not reply to this email: if you want to comment on the bug, go to    
       
the URL shown below and enter yourcomments there.     
   
https://bugs.freedesktop.org/show_bug.cgi?id=4414          
     




------- Additional Comments From billy.biggs at gmail.com  2005-09-15 21:07 -------
Created an attachment (id=3291)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=3291&action=view)
Proposed patch

Here's what I intend to commit.  otaylor and cworth, OK for 1.0.2?

There's actually one other issue not addressed by this patch.  The MMX code is
currently being compiled with both -mmmx and -msse.  The detection code seems
to only check for MMX, not full SSE, so I think this is a problem.  I see three
possible solutions:

   1. Change the detection code to check for SSE, giving up on pre-SSE chips,
      and turn on the USE_SSE define in fbmmx.c.
   2. Compile fbmmx.c twice, once for MMX and once for SSE.
   3. Modify cairo's configure.in to drop -msse

For 1.0.2 I think the only option is 3, as the other two are more risky and I'd
hate to cause new SIGILLs, but I'm confused about why -msse was in there at
all.  Maybe for futureproofing the USE_SSE code?  The current code seems to
compile fine without it.  Am I missing something?          
     
     
--           
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email         
     
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.