[cairo-bugs] [Bug 10151] Add mediaLib support

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=10151





------- Comment #20 from daniel.amelang at gmail.com  2007-11-29 13:11 PST -------
(In reply to comment #19)
> I think the differences in the slowdown's are red herrings, and perhaps due to
> something odd in how the Xserver behaves on Solaris.

That would be my guess, too. You could try running your non-medialib version
multiple times to see if you get the strange behavior, in which case you'd know
more certainly that your patch doesn't introduce this behavior.

> Also the fact that the functions that are patched to use MEDIALIB are
> not even used in the xlib-rgb/xlib-rgba case.

Probably not, unless you hit an image fallback, which AFAIK only happens with
the xlib surface when RENDER isn't available. But you've already pointed out
that it is in this case.

> The reports do show, however, that the functions that do use MEDIALIB
> show consistant speed-up, some of them fairly significant.  So I think
> it is okay to accept this patch.

Sure, although it is a little strange that no one has mentioned having run the
regression tests with this patch. You have, haven't you?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.