[cairo-bugs] [Bug 15367] Improve filtering handling in cairo-pattern.c

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Apr 5 11:28:01 PDT 2008


--- Comment #3 from Owen Taylor <otaylor at redhat.com>  2008-04-05 11:27:58 PST ---
Not going to redo the patch at the moment, but for reference, the "also" hunk

@@ -1677,10 +1735,7 @@ _cairo_pattern_acquire_surface_for_surface
(cairo_surface_pattern_t   *pattern,
            return status;

        /* If we're repeating, we just play it safe and clone the entire
surface. */
-       /* If requested width and height are -1, clone the entire surface.
-        * This is relied on in the svg backend. */
-       if (attr->extend == CAIRO_EXTEND_REPEAT ||
-           (width == (unsigned int) -1 && height == (unsigned int) -1)) {
+       if (attr->extend == CAIRO_EXTEND_REPEAT) {
            x = extents.x;
            y = extents.y;
            width = extents.width;

Which has to be applied *after* the rest of the patch.

The cairo-svg-surface anbd cairo-win32-printing-surface changes
are logically tied to the rest of the patch, since it's not valid to
make the => NEAREST optimization if the image is going to be used on
a SVG surface or printer.

> Great to have you back hacking on cairo, Owen!

Don't expect anything long term, just trying to unbreak my desktop
at the moment, and cairo is a great tool for writing RENDER test
cases. :-)

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list