[cairo-bugs] [Bug 14268] New: Refactor text-antialias-{none, gray, subpixel}. c into a single text-antialias.c test

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Jan 27 14:57:43 PST 2008


           Summary: Refactor text-antialias-{none,gray,subpixel}.c into a
                    single text-antialias.c test
           Product: cairo
           Version: 1.5.7
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: freetype font backend
        AssignedTo: sylvain.pasche at gmail.com
        ReportedBy: sylvain.pasche at gmail.com
         QAContact: cairo-bugs at cairographics.org

Created an attachment (id=13979)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=13979)

The purpose is to reduce code duplication, in particular if we want to add 4
more similar tests for the LCD filtering stuff.

I saw that "make check" accepts running more that one cairo_test in a single
file. In this case the text-antialias test is generating 3
text-antialias-{none,gray,subpixe}.log files.

However there are places where it is assumed that one test maps to only one
.log file. This can be found in all make rules using the
$(TESTS:$(EXEEXT)=.log) construct (check-local, html, ...).

Should we try to get around this assumption? $(wildcard *.log) could be used
instead, with the drawback that it could not detect tests that didn't generate
.log files.

Another way to reduce duplication could be to include a .h file from all these
text-antialias-{none,gray,subpixel}.c files with the shared drawing function.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list