[cairo-bugs] [Bug 18166] New: don' t fill hash tables with dead entries as fast as possible

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=18166

           Summary: don't fill hash tables with dead entries as fast as
                    possible
           Product: cairo
           Version: 1.6.5
          Platform: Other
               URL: https://bugzilla.mozilla.org/show_bug.cgi?id=453200
        OS/Version: All
            Status: RESOLVED
          Severity: normal
          Priority: medium
         Component: general
        AssignedTo: keithp at keithp.com
        ReportedBy: bugs.freedesktop at karlt.net
         QAContact: cairo-bugs at cairographics.org
        Depends on: 18165
            Blocks: 17399



Karl Tomlinson <bugs.freedesktop at karlt.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17399

Chris Wilson <chris at chris-wilson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


Created an attachment (id=19801)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=19801)
patch

modify _cairo_hash_table_lookup_internal to return the first available
(dead or free) entry rather than the first never-used entry, when there is no
match.

This patch actually won't have any effect if bug 18165 is fixed as
first_available won't be set when key_is_unique, and callers that have
key_is_unique == FALSE only care about live entries.

However, this patch could be considered as an alternative to fixing bug 18165,
or just to make the code look sensible.


--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk>  2008-11-07 12:45:55 PST ---
I prefer the patch from bug 18165.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.