[cairo-bugs] [Bug 10301] LCD filtering patch

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jan 27 23:47:07 PST 2009


Brandon Wright <bearoso at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #21150|0                           |1
        is obsolete|                            |

--- Comment #86 from Brandon Wright <bearoso at gmail.com>  2009-01-27 23:47:04 PST ---
Created an attachment (id=22302)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22302)
Revised version of "Fallback to cairo's original LCD filtering if freetype
lacks the capacity"

Ok, I've discovered the problem for my issues. Referring to a patched version
of master, On line 1431 of src/cairo-ft-font.c it tests against the variable
ft_can_filter. However, this variable is only initialized on line 1367 if it's
performing subpixel antialiasing, otherwise it's always false. It ends up using
the internal glyph rasterizer, while it has everything set up for the external
one. Moving the line 1431 testing block to the top level fixes the problem,
with the addition of an extra line to put FT_SetLcdFilter back to normal.

Attached is a version of the patch with said changes made. While I was
modifying it, I noticed that there are some tab/space formatting issues with
the patch that might need to be cleared up.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list