[cairo-bugs] [Bug 10301] LCD filtering patch

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 29 03:02:27 PST 2009


--- Comment #88 from Brandon Wright <bearoso at gmail.com>  2009-01-29 03:02:23 PST ---
(In reply to comment #87)
> Created an attachment (id=22336)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=22336) [details]
> Revised Revised version of the Freetype Filtering with Fallback patch
> Hi Brandon,
> Thanks for catching that! I clearly had a thinko in there. But I don't think
> that bug was causing the behavior you saw. I'm also curious how your changes
> fixed it for you. I recreated the effect you saw, and your patch didn't fix it
> for me. Although it clearly fixes a bug that would have cropped up otherwise.
> I did a more thorough review, and discovered a code block that had been lost.
> I've stuck it back in, and it fixes the problem for me. I've also tried to
> clean up as many of the spacing issues as I could see.
> Nicolaus

It was hitting the correct code path everywhere but in that function, and the
change I made ensured the FT_SetLcdFilter path was used properly there as well.
Your missing code block caused another separate mixed code path error, and you
had the right config to trigger it.

I tested your latest patch, and it works correctly.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list