[cairo-bugs] [Bug 29125] applying a clip can increase the region returned by cairo_copy_clip_rectangle_list

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 16 18:15:24 PDT 2010


Karl Tomlinson <bugs.freedesktop at karlt.net> changed:

           What    |Removed                     |Added
         AssignedTo|cworth at cworth.org           |bugs.freedesktop at karlt.net

--- Comment #1 from Karl Tomlinson <bugs.freedesktop at karlt.net> 2010-07-16 18:15:22 PDT ---
Created an attachment (id=37145)
 View: https://bugs.freedesktop.org/attachment.cgi?id=37145
 Review: https://bugs.freedesktop.org/review?bug=29125&attachment=37145

consider gstate target extents in _cairo_gstate_copy_clip_rectangle_list

Intersecting the clip path with the target surface extents before getting the
region seems better than trying to get a region and then intersecting with the
target extents.  With the later approach, some portion of the clip path beyond
the target could prevent successful generation of the region (or at least
cause unnecessary conversions to rectangles).

I could have left a fast path for unbounded clips but went with the
less-code approach.

There was some inconsistency where lists with zero-rectangles were returned
both for empty clips and unbounded clips.  The tests expect zero rectangles
for empty clips so unbounded clips (on infinite targets) now return

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list