[cairo-bugs] [Bug 30277] Compilation failure due to ffs() when compiling for MinGW

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30277

--- Comment #6 from Neil Roberts <neil at linux.intel.com> 2010-11-02 04:15:17 PDT ---
(In reply to comment #5)

> Here's an untested patch to implement this. Please test.

This patch doesn't compile because the existing implementation of ffs in cairo
is specific to MSVC (the #pragma is an MSVC-ism). The patch in bug 30968
provides the equivalent GCC-ism.

I think the last comment on that bug about avoiding the definition for Cygwin
isn't necessary because Cygwin won't define __WIN32__ because it provides a
Posix emulation layer instead of presenting the Windows API. I'm also not too
familiar with Cygwin however so I'm not 100% sure about that but I did find
some mention in the Cygwin documentation that it doesn't define _WIN32 for that
reason. I'm not sure if we should be using that macro instead or it might make
sense to just check for __MINGW32__ anyway.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.