[cairo-bugs] [Bug 30277] Compilation failure due to ffs() when compiling for MinGW

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30277

--- Comment #10 from Martin Schlemmer <11285613 at nwu.ac.za> 2010-11-11 07:22:50 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Created an attachment (id=40203)
 View: https://bugs.freedesktop.org/attachment.cgi?id=40203
 Review: https://bugs.freedesktop.org/review?bug=30277&attachment=40203

> > cairo-mingw-ffs.patch
> 
> Martin, I thought the idea with the defined(HAVE_FFS) check would be that
> someone would add a check for ffs() in configure.ac? Where would it be defined
> otherwise? I would personally argue that that's not necessary as it's unlikely
> that MinGW would ever add an ffs function and even if they do the #define would
> still work.

Ah, yes, you know what they say about assumption ... Though with it in
config.h, it was tested, never verified.  I can stick in a AC_CHECK_FUNCS, but
yeah, it seems unlikely that it will be implemented.

Do you need an updated patch, or will you just update attached?

Anyhow, give credit to google or one of the original reporters, because that is
how I initially got the workaround as well, just wanted to let you know it
works and not keep waiting.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.