[cairo-bugs] [Bug 33178] Suggestions for cleaning HFONT handling

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 17 13:43:04 PST 2011


--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> 2011-01-17 13:43:03 PST ---
(In reply to comment #2)
> > The various test cases were easy to modify to handle these changes.  However,
> What test cases did you have to modify? I can't find any change related to that
> in your patch

I'm sorry -- I meant that the changes were easy to implement in the
cairo-win32-font.c, not that any test code was modified.

> This is an API change and we should try to avoid it.
> Is there anything that would not be fixed by using select_font/done_font
> correctly
> (i.e. as specified in the documentation) in cairo itself?

I don't think so.  I believe that if the select_font/done_font pairs are
applied properly (and assuming the context is properly restored) everything
would be fine.

My only (small) concern is the fact that "*_done_font" doesn't really seem to
be doing anything; the API user is expected to restore the DC externally.  This
seems a little inconvenient for the user, but I agree that it should work fine.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the cairo-bugs mailing list