[cairo-bugs] [Bug 33318] Crash due to missing cairo_clip_init call in cairo_gstate_show_text_glyphs

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 21 01:32:26 PST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=33318

--- Comment #1 from Andrea Canciani <ranma42 at gmail.com> 2011-01-21 01:32:23 PST ---
I don't like the fact that clip will get initialized twice in your patch.
It would easily be forgotten and break if clip init/fini were changed.

I think it would be better to only clip_init() if
_cairo_scaled_font_glyph_path() fails or to just _gstate_get_clip() in all the
cases.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the cairo-bugs mailing list