[cairo-bugs] [Bug 38049] Hash table contains zero referenced font faces!

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38049

--- Comment #4 from Andrea Canciani <ranma42 at gmail.com> 2011-06-09 00:19:12 PDT ---
(In reply to comment #2)
> Created an attachment (id=47726)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=47726)
> Simple example that shows the bug under windows.
> 
> I've added an file that shows the bug i'm talking about. It also includes the
> whole patch.

I can confirm that your program triggers the bug and your patch fixes it.

> 
> Maybe the test crashes because there is a second thing i have forgotten. In the
> "_cairo_win32_font_face_hash_table_destroy" there is an argument missing to
> "_cairo_hash_table_random_entry". The attachment includes this.
> 
> This is the first time i'm using git but i will try myself to upload this patch
> and other patches.

I tried to improve your patch a little (see the new attachment).

Some investigation of the magic 0 hash might be needed before merging (and I'm
probably going to make your program a cairo testcase so that it can be easily
run along with the other regression tests).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.