[cairo-bugs] [Bug 37049] a small type in the "desc.flags" when creating a wnidow.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37049

Andrea Canciani <ranma42 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Andrea Canciani <ranma42 at gmail.com> 2011-06-20 03:08:30 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=46520)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46520
 Review: https://bugs.freedesktop.org/review?bug=37049&attachment=46520

> > Fix the desc.flags when creating a DirectFB window
> 
> I also removed:
> desc.caps  = DSCAPS_NONE;
> 
> because the "desc.caps" filed won't be taken into account unless the flags
> "DWDESC_CAPS" is specified in the "desc.flags".
> 
> regards.
> Haithem.

Fixed in:

commit 8fb9a6727e2b769bfa388c6027ebad0a53ffa02b
Author: Haithem Rahmani <haithem.rahmani at gmail.com>
Date:   Mon Jun 20 11:16:14 2011 +0200

    boilerplate: Use correct flag type in DFBWindowDescription

    The window description flag macros are prefixed with DWDESC_.

    The issue was not noticed because DWDESC_CAPS and DSDESC_CAPS have the
    same value.

    Fixes https://bugs.freedesktop.org/show_bug.cgi?id=37049


I left the .caps alone, as they are or'ed later.
Thank you for your patch!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.