[cairo-bugs] [Bug 34012] check-plt.sh doesn't correctly detect the absence of readelf

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34012

--- Comment #7 from Tim Mooney <Tim.Mooney at ndsu.edu> 2011-03-16 16:22:24 PDT ---
Ok, I went through all the check-*.sh scripts in src and added code to check
for the presence and GNU lineage of the tools that currently require GNU
syntax.

Could someone review and test the attached patch please?

I now get

/local/gnu/bin/gmake  check-TESTS
gmake[4]: Entering directory `/local/src/RPM/BUILD/cairo-1.10.2/src'
GNU diff not found; skipping test
SKIP: check-def.sh
GNU grep not found; skipping test
SKIP: check-doc-syntax.sh
GNU grep not found; skipping test
SKIP: check-headers.sh
'readelf' not found; skipping test
SKIP: check-plt.sh
Checking that public header files #include "cairo.h" first (or none)
Checking that private header files #include "some cairo header" first (or none)
Checking that source files #include "cairoint.h" first (or none)
glew/glew.c:#include <GL/glew.h>
Checking that there is no #include <cairo.*.h>
Checking that feature conditionals are used with #if only (not #ifdef)
FAIL: check-preprocessor-syntax.sh
Check linking to the just built cairo library
PASS: check-link
========================================================================
1 of 2 tests failed
(4 tests were not run)
Please report to http://bugs.freedesktop.org/enter_bug.cgi?product=cairo
========================================================================

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.