[cairo-bugs] [Bug 37050] CAIRO_FORMAT_RGB24 mapped to wrong DirectFB pixelformat.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37050

Andrea Canciani <ranma42 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NOTABUG

--- Comment #1 from Andrea Canciani <ranma42 at gmail.com> 2011-05-09 23:49:37 PDT ---
(In reply to comment #0)
> Hi,
> 
> in the file "src/cairo-directfb-surface"
> CAIRO_FORMAT_RGB24 should be mapped to DSPF_RGB24 instead of DSPF_RGB32.

I don't think so. The DirectFB documentation
(http://directfb.org/docs/DirectFB_Reference_1_5/types.html#DFBSurfacePixelFormat)
states:
DSPF_RGB24         DFB_SURFACE_PIXELFORMAT( 2, 24, 0, 0, 0, 3, 0, 0, 0, 0, 0 ) 
       24 bit RGB (3 byte, red 8 at 16, green 8 at 8, blue 8 at 0)
DSPF_RGB32         DFB_SURFACE_PIXELFORMAT( 3, 24, 0, 0, 0, 4, 0, 0, 0, 0, 0 ) 
       24 bit RGB (4 byte, nothing at 24, red 8 at 16, green 8 at 8, blue 8 at 0)

So we obviously need DSPF_RGB32, because:

CAIRO_FORMAT_RGB24 each pixel is a 32-bit quantity, with the upper 8 bits
unused. Red, Green, and Blue are stored in the remaining 24 bits in that order.

(from
http://www.cairographics.org/manual/cairo-Image-Surfaces.html#cairo-format-t )

Please check again and reopen if I'm missing something.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.