[cairo-bugs] [Bug 38516] Make Text in generated SVG file selectable

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38516

--- Comment #9 from Behdad Esfahbod <freedesktop at behdad.org> 2011-09-16 09:48:56 PDT ---
Review of attachment 51257:
 --> (https://bugs.freedesktop.org/review?bug=38516&attachment=51257)

1. I'm sure we have UTF-8 functions you can reuse.  You seem to have copied
from glib, which has licensing problems too.

2. Most fonts actually have a upem of 2048.  TrueType fonts that is.  Just
don't mess with the precision for now.  The big win is to store them in upem
units as ints.  But that should be a followup patch.

::: src/cairo-svg.h
@@ +52,3 @@
 } cairo_svg_version_t;

+typedef cairo_status_t (*cairo_write_image_func_t) (void          *closure,

What's this?!

@@ +79,3 @@

+cairo_public void
+cairo_svg_set_support_text_glyphs (cairo_surface_t         *surface,

Wrong.  No need to have this.  User can decide whether to call
cairo_show_glyphs() or cairo_show_text_glyphs() for themselves.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.