[cairo-bugs] [Bug 41020] cairo-test-suite crashes when using CAIRO_TESTS

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Sep 21 08:19:07 PDT 2011


--- Comment #2 from S Boucher <stbya at yahoo.com> 2011-09-21 08:19:05 PDT ---
Strictly speaking, the description of the bug in commit
669242c2c8009b2a257131ba1a3cf497b9472cc4 is wrong.

append_argv doesn't assume that only 1 arg is appended.  It doesn't even
correctly append a single arg, as Paulo points out with his example:
"CAIRO_TESTS=a1-bug make test".

The +1 is there to have a argv[argc] == NULL, as far as I can tell.

All in all, it probably would have been clearer in the first place to have:

char** get_test_lists(int argc, char **argv, const char *env_tests_string)

and adjust main() accordingly.  Overriding argv seems too clever.

But this nitpicking aside. If make test/make retest isn't used, it would be
nice to know how core developpers prefer to run tests.  It's helpful for those
(like me) that arrive out of the blue to look at cairo, and try to figure out
how things come together.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the cairo-bugs mailing list