[cairo-bugs] [Bug 48489] Build fails with unreferenced _cairo_xlib_screen_put_gc error symbol

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=48489

Uli Schlachter <psychon at znc.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
          Component|xcb backend                 |xlib backend

--- Comment #2 from Uli Schlachter <psychon at znc.in> 2012-04-11 12:46:47 PDT ---
Wonders? Me?

Anyway, from a quick look at this, the proposed solution looks correct to me. I
even managed to convince GCC to generate the same error message.

commit 07fc63676dfdaa57ed919ad7be8f59c97c615473
Author: Uli Schlachter <psychon at znc.in>
Date:   Wed Apr 11 21:37:55 2012 +0200

    xlib: Disable fallback compositor with xlib-xcb

    When xlib-xcb is enabled, this is just dead code which is never used. Thus,
this
    shouldn't hurt. However, this does include cairo-xlib-private.h. Shouldn't
be a
    problem? Well, that header contains static inline functions which some
compiler
    on Solaris will emit even when they are unused.

    This brings us to the real problem: That static inline function refers to a
    function which isn't compiled with xlib-xcb and thus linking fails with
    undefined symbols.

    This can be reproduced with GCC by adding a call to
    _cairo_xlib_screen_put_gc(NULL, NULL, 0, 0); to
    _cairo_xlib_fallback_compositor_get.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48489
    Signed-off-by: Uli Schlachter <psychon at znc.in>

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.