[cairo-bugs] [Bug 58727] New: warn_unused_result noise

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=58727

          Priority: medium
            Bug ID: 58727
          Assignee: chris at chris-wilson.co.uk
           Summary: warn_unused_result noise
        QA Contact: cairo-bugs at cairographics.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: dmacks at netspace.org
          Hardware: Other
            Status: NEW
           Version: 1.12.8
         Component: general
           Product: cairo

Building cairo-1.12.8 on OS X 10.6 against pixman-0.28.2, I get a bunch of
warnings about ignored return-codes of functions that assert that their return
should not be ignored:

cairo-path-stroke-polygon.c: In function 'add_caps':
cairo-path-stroke-polygon.c:944: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result
cairo-path-stroke-polygon.c:961: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result
cairo-path-stroke-polygon.c:976: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result
cairo-path-stroke-polygon.c:981: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result
cairo-path-stroke-polygon.c: In function 'close_path':
cairo-path-stroke-polygon.c:1226: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result
cairo-path-stroke-polygon.c:1227: warning: ignoring return value of
'_cairo_polygon_add_contour', declared with attribute warn_unused_result

cairo-polygon-intersect.c: In function 'edges_end':
cairo-polygon-intersect.c:1162: warning: ignoring return value of
'_cairo_polygon_add_line', declared with attribute warn_unused_result
cairo-polygon-intersect.c:1163: warning: ignoring return value of
'_cairo_polygon_add_line', declared with attribute warn_unused_result
cairo-polygon-intersect.c: In function '_cairo_polygon_intersect_with_boxes':
cairo-polygon-intersect.c:1519: warning: ignoring return value of
'_cairo_polygon_add_external_edge', declared with attribute warn_unused_result
cairo-polygon-intersect.c:1522: warning: ignoring return value of
'_cairo_polygon_add_external_edge', declared with attribute warn_unused_result
cairo-polygon-reduce.c: In function '_cairo_bo_edge_end':
cairo-polygon-reduce.c:1163: warning: ignoring return value of
'_cairo_polygon_add_line', declared with attribute warn_unused_result
cairo-polygon-reduce.c:1167: warning: ignoring return value of
'_cairo_polygon_add_line', declared with attribute warn_unused_result

cairo-rectangular-scan-converter.c: In function 'generate_row':
cairo-rectangular-scan-converter.c:625: warning: ignoring return value of
function declared with attribute warn_unused_result

cairo-surface-observer.c: In function 'sync':
cairo-surface-observer.c:665: warning: ignoring return value of
'_cairo_surface_unmap_image', declared with attribute warn_unused_result

Do they need their return-codes handled, or do their prototypes (in cairoint.h
I think) need to allow their return-codes to be ignoreable?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20121224/d2cb778b/attachment.html>