[cairo-bugs] [Bug 43397] EXTEND_NONE is used instead of EXTEND_PAD when src sample area is entirely within the surface

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 20 16:41:11 PST 2012


--- Comment #28 from Konstantin Svist <fry.kun at gmail.com> 2012-01-20 16:41:11 PST ---
So, just to make sure I understand:
Cairo is explicitly disobeying the call's EXTEND_PAD (as per Comment 15) and
replaces it with EXTEND_NONE in this piece of code:

if (attr->extend != CAIRO_EXTEND_REPEAT) {
} else {
 if (sampled_area.x >= extents.x &&
 sampled_area.y >= extents.y &&
 sampled_area.x + (int) sampled_area.width <= extents.x + (int) extents.width
 sampled_area.y + (int) sampled_area.height <= extents.y + (int)
 /* source is wholly contained within extents, drop the REPEAT */
 extents = sampled_area;
 attr->extend = CAIRO_EXTEND_NONE;

Wouldn't it make more sense to simply check for EXTEND_PAD in this code and
skip conversion to EXTEND_NONE? Or maybe check whether or not XRENDER is being
used and if not, don't touch the extend flag?

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.

More information about the cairo-bugs mailing list