[cairo-bugs] [Bug 52936] Race condition in cairo-trace

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=52936

--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> 2012-07-30 08:08:48 UTC ---
You can see the reason why it has to be like that? The trace file is a
sequential stream and can't handle multiple processes simultaneously.

To handle such tracing, the idea was to specify a directory and for each trace
to be written to a separate file (in CAIRO_TRACE_OUTDIR). However, looks like
that's broken if the child is spawned after the logfile is open. Can you please
try:

diff --git a/util/cairo-trace/trace.c b/util/cairo-trace/trace.c
index da7d2f0..f7945e7 100644
--- a/util/cairo-trace/trace.c
+++ b/util/cairo-trace/trace.c
@@ -832,7 +832,7 @@ _init_logfile (void)
                filename, name, getpid());

        filename = buf;
-
+    } else {
        setenv ("CAIRO_TRACE_FD", "-1", 1);
     }

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.