[cairo-bugs] [Bug 54657] commit 0bfd2ac causes great rendering problem is some programs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54657

--- Comment #6 from Chris Wilson <chris at chris-wilson.co.uk> 2012-09-13 11:48:27 UTC ---
Please try commit e2c4bb9465e6261eb79f24af52d339df0b563b55
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Sep 13 12:40:49 2012 +0100

    xlib: Fix regression in cairo_xlib_surface_set_drawable()

    In commit 0bfd2acd35547fc2bd0de99cc67d153f0170697d
    Author: Chris Wilson <chris at chris-wilson.co.uk>
    Date:   Mon Aug 13 01:34:12 2012 +0100

        xlib: Implement SHM fallbacks and fast upload paths

    I made the mistake of inverting the logic for
    cairo_xlib_surface_set_drawable() causing it then to never update.

    Thanks to Uli Schlachter for spotting my error.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=54657
    Reported-by: Weng Xuetian <wengxt at gmail.com>
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

The issue the qtcurves engine ran afoul of was that it was mixing cairo and
external access to its shadow Pixmaps, without flushing the cairo rendering.
That behaviour has been documented since cairo-1.0, and with time we rely upon
it for more optimisations. So long as you observe the requirement to
flush/mark-dirty around non-cairo access to cairo surfaces' Drawable, it should
work on any backend.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.