[cairo-bugs] [Bug 54657] commit 0bfd2ac causes great rendering problem is some programs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=54657

--- Comment #14 from Chris Wilson <chris at chris-wilson.co.uk> 2012-09-13 21:59:31 UTC ---
Yup, the patch is right. My expectation was that the flush would destroy the
damage, but I had forgotten that it would not do so until the fallback was idle
as well. (Migration avoidance).

I pushed the same patch before noticing you had written one, sorry, or else I
would have credited you with the complete fix.


commit 5c59d989f9037f94c80ccd7929dc05f4a95be4df
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Thu Sep 13 22:50:11 2012 +0100

    xlib: Destroy the fallback damage along with the fallback surface

    Whenever we discard the fallback surface, we need to destroy the
    associated damage tracking, so move this into the common discard
    routine.

    This should fix the issue when trying to flush the fallback before
    the user modifies any foreign Drawables. The current code issued the
    flush and then explicitly discard the fallback, but unless it was idle
    at the time of the flush the associated damage would not have also been
    destroyed. Asserts followed.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=54657
    Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

commit 59248fb2628e86ff62abfbf122b88c2a299ec393
Author: Weng Xuetian <wengxt at gmail.com>
Date:   Thu Sep 13 22:56:57 2012 +0100

    xlib: Reset fallback counter when discarding the fallback

    References: https://bugs.freedesktop.org/show_bug.cgi?id=54657

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.