[cairo-bugs] [Bug 57379] [gl, glesv2] Cannot build with --gl and --glesv2

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=57379

--- Comment #2 from ojab <ojab at ojab.ru> ---
Created attachment 77515
  --> https://bugs.freedesktop.org/attachment.cgi?id=77515&action=edit
patch

Cannot bisect, but looks like this issue was fixed/papered over by 
http://cgit.freedesktop.org/cairo/commit/?id=465319ce828f922edce46b6e7628da543b20d5e4
and 
http://cgit.freedesktop.org/cairo/commit/?id=188c34b40d6f08851b4076ad11aefe69d4a78a25
reverted that.

Attached patch fixes the issue (but there is also makefile/libtool one:
gl-related object files are pulled twice during linking).

But I don't understand why not rewrite _get_depth_stencil_format to just

static GLenum
_get_depth_stencil_format (cairo_gl_context_t *ctx)
{
    /* This is necessary to properly handle the situation where both
       OpenGL and OpenGLES are active and returning a sane default. */
#if CAIRO_HAS_GL_SURFACE
    return GL_DEPTH_STENCIL;
#endif

#if CAIRO_HAS_GLESV2_SURFACE
    return GL_DEPTH24_STENCIL8;
#endif
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20130406/485bacc5/attachment-0001.html>