[cairo-bugs] [Bug 61876] Regression since 1.11.4: Corrupt drawing on mingw64 build used with virt-viewer 0.5.5 binaries

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=61876

--- Comment #4 from Marc-Andre Lureau <marcandre.lureau at gmail.com> ---
(In reply to comment #2)
> (In reply to comment #0)
> [...]
> > Unfortunately, I was unable to do a git bisect between them due to hitting
> > several compilation issues.
> [...]
> 
> Do you happen to have the final range of possible-faulty commits around? Did
> you use "git bisect skip" to "work around" those compile issues?

unfortunately, no. As Grant C. is saying, many commits do not build on win32
(>90%). I am afraid git bisect is not going to be of any help, there has been
too much win32 broken change between 1.11.2 and 1.11.4

> (In reply to comment #1)
> You have a reference leak in spicex_image_destroy(). You have to call
> cairo_surface_destroy() even when you call cairo_surface_finish(). The
> latter function doesn't drop any references.

Ah, thanks for pointing out!

> Since this mentions DLLs and mingw64: The problem should be in
> cairo-windows, right? The image surface used as d->ximage contains the
> correct data?

Yes: hiding & showing back the widget or widget region is enough to fix the
display (also the scaled version is correct, and using older version of cairo
works)

> Now that I have written this question: Do you call
> cairo_surface_mark_dirty() / cairo_surface_mark_dirty_rectangle() /
> cairo_surface_flush() where needed?

No, we never did that, but should probably!

> You could try inserting a call to cairo_surface_mark_dirty(d->ximage) at the
> beginning of spicex_draw_event() and see if it helps (but of course this is
> not a fix, the code which messes with the image data should mark it dirty
> instead)

Unfortunately, it didn't help.

Thanks for your suggestions!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20130326/e1fc5cf7/attachment.html>