[cairo-bugs] [Bug 75819] _cairo_clip_set_all_clipped returns const value as non-const, caller modifies it -> crash on some platforms

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=75819

--- Comment #3 from Uli Schlachter <psychon at znc.in> ---
Chris, done. For something completely different (which really doesn't belong
into this comment): Could you take a look at _cairo_clip_reduce_to_boxes()?
That function has an unconditional "return clip" with wrong indentation as its
first executed statement. That doesn't seem right...

commit ed175b2a2bebb6def85133257bc11a875d13b0dd
Author: Uli Schlachter <psychon at znc.in>
Date:   Thu Mar 6 09:45:08 2014 +0100

    clip: Fix handling of special all-clipped cairo_clip_t

    _cairo_clip_intersect_box() wasn't checking if it was called with the
special,
    read-only all-clipped clip and thus could have ended up writing to
read-only
    memory.

    References: https://bugs.freedesktop.org/show_bug.cgi?id=75819
    Signed-off-by: Uli Schlachter <psychon at znc.in>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20140306/31337092/attachment-0001.html>