[cairo-bugs] [Bug 84044] test/cairo-test-suite reports wrong max diff comparing different opaque images

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=84044

--- Comment #3 from Massimo <sixtysix at inwind.it> ---
(In reply to Uli Schlachter from comment #2)
> Isn't the bug here really in the code that compares the images?
> 
> You are blaming test/buffer-diff.c line 80 which is:
> 
>    if ((row_a[x] & mask) != (row_b[x] & mask))
> 

I blamed test/buffer-diff.c because when that condition is
TRUE, the maximum diff computed includes also the non-alpha
channel:

http://cgit.freedesktop.org/cairo/tree/test/buffer-diff.c#n85

So my first observation was reading a test log in which
two identical images (argb32 and rgb24) had reported two
max diff values compared to the same reference.

yes, there are also other bugs in test/pdiff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20141004/76f59744/attachment.html>