[cairo-bugs] [Bug 89533] New: pdftocairo -svg produced garbaged shadows in the ouput file

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89533

            Bug ID: 89533
           Summary: pdftocairo -svg produced garbaged shadows in the ouput
                    file
           Product: cairo
           Version: 1.12.4
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: quartz backend
          Assignee: vladimir at pobox.com
          Reporter: rapatsky at gmail.com
        QA Contact: cairo-bugs at cairographics.org

Created attachment 114219
  --> https://bugs.freedesktop.org/attachment.cgi?id=114219&action=edit
File with shadows, which garbaged during PDF->SVG conversion

When converting attached file to SVG, I see that square and star objects
shadows are missing. I've used pdftocairo version 0.24.6. Command:
pdftocairo -svg testlinks.pdf

Using git bisect I've found that first commit where shadow rendering was broken
is

commit 8020e0bc8cbd3e5ac188eb305b74ae1c1f362a31
Author: Chris Wilson <chris at chris-wilson.co.uk>
Date:   Wed Oct 3 17:01:41 2012 +0100

In that commit file src/cairo-recording-surface.c was changed.

If I revert this part of diff patch, then shadows rendering brings back.

@@ -1131,7 +1441,7 @@ _cairo_recording_surface_snapshot (void *abstract_other)
     surface->optimize_clears = TRUE;

     _cairo_array_init (&surface->commands, sizeof (cairo_command_t *));
-    status = _cairo_recording_surface_replay (&other->base, &surface->base);
+    status = _cairo_recording_surface_copy (other, surface);
     if (unlikely (status)) {
        cairo_surface_destroy (&surface->base);
        return _cairo_surface_create_in_error (status);

Could you please help me to fix _cairo_recording_surface_copy function to
support shadows?

In the latest cairo builds shadows are broken even more. They are not absent,
but rendered as gray rectangles under the objects.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo-bugs/attachments/20150311/9a363184/attachment.html>