[cairo-bugs] [Bug 104325] cairo 1.14.12 hangs in read_png called from cairo_image_surface_create_from_png_stream on malformed png

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sun Dec 24 12:25:57 UTC 2017


--- Comment #6 from Uli Schlachter <psychon at znc.in> ---
@Orivej Desh: Okay, thanks for testing & sorry that I was wrong. I was thinking
"surely there is a test for this" and wondered why only NixOS noticed this bug.
My logic was "if the compiler inlines this new function, then everything should
still work, so it can only be on NixOS that the inlining does not happen". I
did not actually know that compilers are smart enough to detect setjmp() as
doing "weird things".

Anyway, I went ahead and now wrote a test for this (no, cairo did not yet have
one already). Pushed as commit 6b0593827b072abd701ea47448981bcc9bdde9f3.
(And yes, this test fails before the faulty commit is reverted and passed after
the revert.)

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20171224/d4e001a3/attachment.html>

More information about the cairo-bugs mailing list