[cairo-bugs] [Bug 103037] Segmentation fault in _cairo_traps_compositor_glyphs

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=103037

--- Comment #25 from Uli Schlachter <psychon at znc.in> ---
Comment on attachment 134722
  --> https://bugs.freedesktop.org/attachment.cgi?id=134722
Surround initialisations with atomic critical section

Review of attachment 134722:
-----------------------------------------------------------------

+1 for the patch, thanks!

> However I have run some more tests and it now looks like gcc (4.8.2) produces identical code for "if (y)" and "if (__atomic_load_n(&y,__ATOMIC_X))" for all valid values of X, even SEQ_CST (!). I was basing my comments on attempts to use the __sync operations. Absolutely I would recommend using __atomic in all code from now on (if in fact gcc is correct, I am surprised there is no sync or other added instruction).
> 
> It seems correct to use the acquire/release types for this init flag, but since it produces identical code on x86 there could be a worry that this will be insufficiently tested.

According to the second result Google gave me, this is correct:
https://www.cl.cam.ac.uk/~pes20/cpp/cpp0xmappings.html

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo-bugs/attachments/20171013/9d1f6e33/attachment.html>