<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - TSan data races with freed_pool_t's |top| data member" href="https://bugs.freedesktop.org/show_bug.cgi?id=90318#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - TSan data races with freed_pool_t's |top| data member" href="https://bugs.freedesktop.org/show_bug.cgi?id=90318">bug 90318</a> from <a class="email" href="mailto:wtc@google.com" title="Wan-Teh Chang <wtc@google.com>"> Wan-Teh Chang</a> <pre>Comment on <a href="attachment.cgi?id=121989" name="attach_121989" title="Hack adding C11 atomics for setting pool->top">attachment 121989</a> <a href="attachment.cgi?id=121989&action=edit" title="Hack adding C11 atomics for setting pool->top">[details]</a> <a href='page.cgi?id=splinter.html&bug=90318&attachment=121989'>[review]</a> Hack adding C11 atomics for setting pool->top Review of <a href="attachment.cgi?id=121989" name="attach_121989" title="Hack adding C11 atomics for setting pool->top">attachment 121989</a> <a href="attachment.cgi?id=121989&action=edit" title="Hack adding C11 atomics for setting pool->top">[details]</a> <a href='page.cgi?id=splinter.html&bug=90318&attachment=121989'>[review]</a>: ----------------------------------------------------------------- Hi Uli, I've tested such a patch in <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1161170#c4">https://bugzilla.mozilla.org/show_bug.cgi?id=1161170#c4</a>. It works. I will attach a proper patch based on the GCC __atomic builtin functions next. Why did't I use C11 atomics in the patch I'm about to attach? A new implementation of the _cairo_atomic_xxx functions based on C11 atomics will require changes to function prototypes because C11 distinguishes between the |atomic_int| and |int| types whereas Cairo uses the cairo_atomic_int_t type for both purposes.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> </ul> </body> </html>